tami/gst-plugin-linescan
6
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix caps to avoid videoconvert bug in 1.8 which corrupts data

Browse Source 
Previous way of creating caps left invalid colorimetry field 0:0:0:0,
which combined with a bug present in GStreamer 1.8 led to GRAY16_LE data
being corrupted when converted to GRAY16_BE (or vice versa). Current
method will properly initialize colorimetry field, avoiding this problem
in 1.8.
This commit is contained in:
Joshua M. Doe
2017-11-16 08:27:08 -05:00
parent f76390323f
commit e4a308a545
10 changed files with 55 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
sys/edt/gstedtpdvsink.c
View File

@@ -219,7 +219,7 @@ GstCaps *
gst_edt_pdv_sink_get_caps (GstBaseSink * basesink, GstCaps * filter_caps)
{
GstEdtPdvSink *pdvsink = GST_EDT_PDV_SINK (basesink);
gint depth;
gint width, height, depth;
GstVideoFormat format;
GstVideoInfo vinfo;
@@ -229,8 +229,8 @@ gst_edt_pdv_sink_get_caps (GstBaseSink * basesink, GstCaps * filter_caps)
}
gst_video_info_init (&vinfo);
vinfo.width = pdv_get_width (pdvsink->dev);
vinfo.height = pdv_get_height (pdvsink->dev);
width = pdv_get_width (pdvsink->dev);
height = pdv_get_height (pdvsink->dev);
depth = pdv_get_depth (pdvsink->dev);
switch (depth) {
@@ -244,7 +244,7 @@ gst_edt_pdv_sink_get_caps (GstBaseSink * basesink, GstCaps * filter_caps)
default:
format = GST_VIDEO_FORMAT_UNKNOWN;
}
vinfo.finfo = gst_video_format_get_info (format);
gst_video_info_set_format (&vinfo, format, width, height);
/* TODO: handle filter_caps */
return gst_video_info_to_caps (&vinfo);

14
sys/edt/gstedtpdvsrc.c
View File

@@ -345,26 +345,26 @@ gst_edt_pdv_src_get_caps (GstBaseSrc * bsrc, GstCaps * filter)
if (src->dev == NULL) {
caps = gst_pad_get_pad_template_caps (GST_BASE_SRC_PAD (src));
} else {
gint depth;
gint width, height, depth;
GstVideoInfo vinfo;
/* Create video info */
gst_video_info_init (&vinfo);
vinfo.width = pdv_get_width (src->dev);
vinfo.height = pdv_get_height (src->dev);
width = pdv_get_width (src->dev);
height = pdv_get_height (src->dev);
depth = pdv_get_depth (src->dev);
if (depth <= 8) {
vinfo.finfo = gst_video_format_get_info (GST_VIDEO_FORMAT_GRAY8);
gst_video_info_set_format (&vinfo, GST_VIDEO_FORMAT_GRAY8, width, height);
caps = gst_video_info_to_caps (&vinfo);
} else if (depth <= 16) {
GValue val = G_VALUE_INIT;
GstStructure *s;
/* TODO: check endianness */
vinfo.finfo = gst_video_format_get_info (GST_VIDEO_FORMAT_GRAY16_LE);
gst_video_info_set_format (&vinfo, GST_VIDEO_FORMAT_GRAY16_LE, width,
height);
caps = gst_video_info_to_caps (&vinfo);
/* set bpp, extra info for GRAY16 so elements can scale properly */
@@ -374,7 +374,7 @@ gst_edt_pdv_src_get_caps (GstBaseSrc * bsrc, GstCaps * filter)
gst_structure_set_value (s, "bpp", &val);
g_value_unset (&val);
} else if (depth == 24) {
vinfo.finfo = gst_video_format_get_info (GST_VIDEO_FORMAT_RGB);
gst_video_info_set_format (&vinfo, GST_VIDEO_FORMAT_RGB, width, height);
caps = gst_video_info_to_caps (&vinfo);
} else {
GST_ELEMENT_ERROR (src, STREAM, WRONG_TYPE,