From 87b92a8f793a9214a0c74e896489f814c9156a24 Mon Sep 17 00:00:00 2001 From: "Joshua M. Doe" Date: Wed, 15 Jan 2014 08:58:14 -0500 Subject: [PATCH] framelinksrc: show error code on failure and fix some formatting --- sys/imperx/gstframelinksrc.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/sys/imperx/gstframelinksrc.c b/sys/imperx/gstframelinksrc.c index 2cec2bb..5011200 100644 --- a/sys/imperx/gstframelinksrc.c +++ b/sys/imperx/gstframelinksrc.c @@ -318,13 +318,16 @@ gst_framelinksrc_start (GstBaseSrc * bsrc) /* TODO: use VCECLB_InitByHandle */ src->grabber = VCECLB_Init (); if (src->grabber == NULL) { - GST_ELEMENT_ERROR (src, RESOURCE, OPEN_READ, ("Failed to initialize grabber"), (NULL)); /* TODO: get error string */ + GST_ELEMENT_ERROR (src, RESOURCE, OPEN_READ, + ("Failed to initialize grabber (code %d)", VCECLB_CardLastError ()), + (NULL)); return FALSE; } err = VCECLB_GetDMAAccessEx (src->grabber, src->channel); if (err != VCECLB_Err_Success) { - GST_ELEMENT_ERROR (src, RESOURCE, OPEN_READ, ("Failed to get DMA access to port on grabber"), (NULL)); /* TODO: get error string */ + GST_ELEMENT_ERROR (src, RESOURCE, OPEN_READ, + ("Failed to get DMA access to port on grabber (code %d)", err), (NULL)); return FALSE; } @@ -332,7 +335,8 @@ gst_framelinksrc_start (GstBaseSrc * bsrc) VCECLB_PrepareEx (src->grabber, src->channel, &camConfig.pixelInfo.cameraData); if (err != VCECLB_Err_Success) { - GST_ELEMENT_ERROR (src, RESOURCE, SETTINGS, ("Failed to configure grabber"), (NULL)); /* TODO: get error string */ + GST_ELEMENT_ERROR (src, RESOURCE, SETTINGS, + ("Failed to configure grabber (code %d)", err), (NULL)); return FALSE; } @@ -392,13 +396,13 @@ gst_framelinksrc_stop (GstBaseSrc * bsrc) if (src->acq_started) { VCECLB_StopGrabEx (src->grabber, src->channel); - src->acq_started = FALSE; + src->acq_started = FALSE; } if (src->grabber) { - VCECLB_ReleaseDMAAccessEx (src->grabber, src->channel); - VCECLB_Done (src->grabber); - src->grabber = NULL; + VCECLB_ReleaseDMAAccessEx (src->grabber, src->channel); + VCECLB_Done (src->grabber); + src->grabber = NULL; } src->dropped_frame_count = 0;