From 8dcf24d0f39db84b3728dcd9db5c7869fff2ed3e Mon Sep 17 00:00:00 2001
From: "Joshua M. Doe" <oss@nvl.army.mil>
Date: Thu, 21 Jan 2021 13:57:48 -0500
Subject: [PATCH] qcamsrc: send camera settings as a group

---
 sys/qcam/gstqcamsrc.c | 22 +++++++++++++---------
 sys/qcam/gstqcamsrc.h |  1 +
 2 files changed, 14 insertions(+), 9 deletions(-)

diff --git a/sys/qcam/gstqcamsrc.c b/sys/qcam/gstqcamsrc.c
index e01262c..d6bb78f 100644
--- a/sys/qcam/gstqcamsrc.c
+++ b/sys/qcam/gstqcamsrc.c
@@ -268,7 +268,6 @@ static void
 gst_qcamsrc_set_exposure (GstQcamSrc * src, unsigned long exposure)
 {
   QCam_SetParam (&src->qsettings, qprmExposure, exposure);
-  QCam_SendSettingsToCam (src->handle, &src->qsettings);
 }
 
 static void
@@ -276,14 +275,12 @@ gst_qcamsrc_set_gain (GstQcamSrc * src, float gain)
 {
   QCam_SetParam (&src->qsettings, qprmNormalizedGain,
       (unsigned long) (gain * 1000000));
-  QCam_SendSettingsToCam (src->handle, &src->qsettings);
 }
 
 static void
 gst_qcamsrc_set_offset (GstQcamSrc * src, long offset)
 {
   QCam_SetParamS32 (&src->qsettings, qprmS32AbsoluteOffset, offset);
-  QCam_SendSettingsToCam (src->handle, &src->qsettings);
 }
 
 
@@ -307,18 +304,15 @@ gst_qcamsrc_set_property (GObject * object, guint property_id,
       break;
     case PROP_EXPOSURE:
       src->exposure = g_value_get_uint (value);
-      if (src->handle)
-        gst_qcamsrc_set_exposure (src, src->exposure);
+      src->send_settings = TRUE;
       break;
     case PROP_GAIN:
       src->gain = g_value_get_double (value);
-      if (src->handle)
-        gst_qcamsrc_set_gain (src, src->gain);
+      src->send_settings = TRUE;
       break;
     case PROP_OFFSET:
       src->offset = g_value_get_int (value);
-      if (src->handle)
-        gst_qcamsrc_set_offset (src, src->offset);
+      src->send_settings = TRUE;
       break;
     case PROP_FORMAT:
       src->format = g_value_get_int (value);
@@ -528,6 +522,8 @@ gst_qcamsrc_setup_stream (GstQcamSrc * src)
   gst_qcamsrc_set_exposure (src, src->exposure);
   gst_qcamsrc_set_gain (src, src->gain);
   gst_qcamsrc_set_offset (src, src->offset);
+  QCam_SendSettingsToCam (src->handle, &src->qsettings);
+  src->send_settings = FALSE;
 
   err = QCam_GetInfo (src->handle, qinfCcdWidth, &width);
   err = QCam_GetInfo (src->handle, qinfCcdHeight, &height);
@@ -723,6 +719,14 @@ gst_qcamsrc_create (GstPushSrc * psrc, GstBuffer ** buf)
     return GST_FLOW_FLUSHING;
   }
 
+  if (src->handle && src->send_settings) {
+    gst_qcamsrc_set_exposure (src, src->exposure);
+    gst_qcamsrc_set_gain (src, src->gain);
+    gst_qcamsrc_set_offset (src, src->offset);
+    QCam_QueueSettings (src->handle, &src->qsettings, NULL, 0, 0, 0);
+    src->send_settings = FALSE;
+  }
+
   return GST_FLOW_OK;
 }
 
diff --git a/sys/qcam/gstqcamsrc.h b/sys/qcam/gstqcamsrc.h
index c17cd27..136266b 100644
--- a/sys/qcam/gstqcamsrc.h
+++ b/sys/qcam/gstqcamsrc.h
@@ -41,6 +41,7 @@ struct _GstQcamSrc
 
   /* camera handle */
   QCam_Handle handle;
+  gboolean send_settings;
   QCam_Settings qsettings;
 
   /* properties */