From e4e231fca85fa20190b2860a1ac2048647fd6bcd Mon Sep 17 00:00:00 2001 From: Eskild Helmersen Date: Sat, 16 May 2020 19:03:19 +0200 Subject: [PATCH] pylonsrc: the limits of some of the transport-layer parameters are codependent, and must be adjusted accordingly See Pylon manuals, and PylonViewer, to understand these relations. --- sys/pylon/gstpylonsrc.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sys/pylon/gstpylonsrc.c b/sys/pylon/gstpylonsrc.c index 1ec4e44..24137fd 100644 --- a/sys/pylon/gstpylonsrc.c +++ b/sys/pylon/gstpylonsrc.c @@ -752,31 +752,31 @@ gst_pylonsrc_class_init (GstPylonSrcClass * klass) g_param_spec_int ("packet-size", "Maximum size of data packet", "The packetsize parameter specifies the maximum size of a data packet transmitted via Ethernet. The value is in bytes.", 0, 16000, DEFAULT_PROP_PACKETSIZE, - (GParamFlags) (G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS))); + (GParamFlags) (G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS))); //TODO: Limits may be co-dependent on other transport layer parameters. g_object_class_install_property (gobject_class, PROP_INTERPACKETDELAY, g_param_spec_int ("inter-packet-delay", "Inter-Packet Delay between packet transmissions", "If your network hardware can't handle the incoming packet rate, it is useful to increase the delay between packet transmissions.", 0, 3435, DEFAULT_PROP_INTERPACKETDELAY, - (GParamFlags) (G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS))); + (GParamFlags) (G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS))); //TODO: Limits may be co-dependent on other transport layer parameters. g_object_class_install_property (gobject_class, PROP_FRAMETRANSDELAY, g_param_spec_int ("frame-trans-delay", "Delay for begin transmitting frame.", "Sets a delay in ticks between when camera begisn transmitting frame afther acquiring it. By default, one tick equals 8 ns. With PTP enabled, one tick equals 1 ns.", 0, 50000000, DEFAULT_PROP_FRAMETRANSDELAY, - (GParamFlags) (G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS))); + (GParamFlags) (G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS))); //TODO: Limits may be co-dependent on other transport layer parameters. g_object_class_install_property (gobject_class, PROP_BANDWIDTHRESERVE, g_param_spec_int ("bandwidth-reserve", "Portion of bandwidth reserved for packet resends.", "The setting is expressed as a percentage of the assigned bandwidth.", 0, 26, DEFAULT_PROP_BANDWIDTHRESERVE, - (GParamFlags) (G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS))); + (GParamFlags) (G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS))); //TODO: Limits may be co-dependent on other transport layer parameters. g_object_class_install_property (gobject_class, PROP_BANDWIDTHRESERVEACC, g_param_spec_int ("bandwidth-reserve-acc", "Pool of resends for unusual situations", "For situations when the network connection becomes unstable. A larger number of packet resends may be needed to transmit an image", 1, 32, DEFAULT_PROP_BANDWIDTHRESERVEACC, - (GParamFlags) (G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS))); + (GParamFlags) (G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS))); //TODO: Limits may be co-dependent on other transport layer parameters. } static gboolean