Wolfgang Denk 54841ab50c
Make sure that argv[] argument pointers are not modified. ...
The hush shell dynamically allocates (and re-allocates) memory for the
argument strings in the "char *argv[]" argument vector passed to
commands. Any code that modifies these pointers will cause serious
corruption of the malloc data structures and crash U-Boot, so make
sure the compiler can check that no such modifications are being done
by changing the code into "char * const argv[]".
This modification is the result of debugging a strange crash caused
after adding a new command, which used the following argument
processing code which has been working perfectly fine in all Unix
systems since version 6 - but not so in U-Boot:
int main (int argc, char **argv)
{
while (--argc > 0 && **++argv == '-') {
/* ====> */ while (*++*argv) {
switch (**argv) {
case 'd':
debug++;
break;
...
default:
usage ();
}
}
}
...
}
The line marked "====>" will corrupt the malloc data structures and
usually cause U-Boot to crash when the next command gets executed by
the shell. With the modification, the compiler will prevent this with
an
error: increment of read-only location '*argv'
N.B.: The code above can be trivially rewritten like this:
while (--argc > 0 && **++argv == '-') {
char *arg = *argv;
while (*++arg) {
switch (*arg) {
...
Signed-off-by: Wolfgang Denk <wd@denx.de >
Acked-by: Mike Frysinger <vapier@gentoo.org >
2010-07-04 23:55:42 +02:00
2010-05-06 00:17:01 +02:00
2010-07-04 23:55:42 +02:00
2010-07-04 23:48:55 +02:00
2008-03-03 22:08:08 +01:00
2008-10-18 21:54:03 +02:00
2010-03-21 22:44:59 +01:00
2010-05-06 00:17:01 +02:00
2010-04-13 09:13:04 +02:00
2009-10-28 11:34:14 +01:00
2010-04-13 09:13:04 +02:00
2010-03-21 22:22:53 +01:00
2009-08-09 22:34:51 +02:00
2010-05-07 00:17:30 +02:00
2009-11-23 16:27:02 +01:00
2009-02-10 00:27:40 +01:00
2009-08-09 23:15:33 +02:00
2009-10-03 10:17:56 +02:00
2008-12-15 22:05:36 +01:00
2009-07-29 09:59:22 +02:00
2009-03-20 22:39:13 +01:00
2009-10-03 10:17:56 +02:00
2010-01-27 21:23:14 +01:00
2008-04-13 09:59:26 -07:00
2009-02-18 00:39:44 +01:00
2008-05-21 00:14:08 +02:00
2009-04-04 20:42:19 +02:00
2008-10-18 21:54:03 +02:00
2008-05-10 11:44:55 +02:00
2009-08-25 12:57:55 +02:00
2008-05-21 00:14:08 +02:00
2009-07-26 13:17:21 +02:00
2008-05-21 00:14:08 +02:00
2010-07-04 23:55:42 +02:00
2010-07-04 23:55:42 +02:00
2009-03-18 20:50:04 +01:00
2010-06-20 02:21:58 +02:00
2010-04-10 22:19:42 +02:00
2009-10-27 20:58:25 +01:00
2010-01-26 00:04:57 +01:00
2008-10-18 21:54:03 +02:00
2009-03-30 13:33:50 -05:00
2009-01-24 00:23:09 +01:00
2009-06-08 22:57:21 -07:00
2008-05-21 00:14:08 +02:00
2009-09-04 21:54:52 +02:00
2009-01-24 01:47:50 +01:00
2008-10-18 21:54:03 +02:00
2009-09-24 12:05:29 -05:00
2009-07-19 21:41:46 +02:00
2010-07-04 23:52:42 +02:00
2010-07-04 23:55:42 +02:00
2008-12-04 20:51:44 +01:00
2010-04-07 00:08:18 -05:00
2008-09-13 02:03:38 +02:00
2008-03-26 23:38:54 +01:00
2009-08-26 08:58:27 +02:00
2009-10-03 10:17:56 +02:00
2010-04-23 21:02:30 -05:00
2010-01-27 14:22:41 -06:00
2010-05-05 09:48:41 +02:00
2008-10-18 21:54:02 +02:00
2009-07-16 22:23:53 +02:00
2010-04-19 07:46:35 +02:00
2008-10-18 21:54:03 +02:00
2009-09-25 01:22:13 +02:00
2010-07-04 23:55:42 +02:00
2009-07-18 00:27:46 +02:00
2010-07-04 23:55:42 +02:00
2009-10-13 06:17:35 -05:00
2009-07-26 13:16:50 +02:00
2008-10-18 21:54:03 +02:00
2008-04-13 23:20:16 -07:00
2009-07-19 21:41:46 +02:00
2009-04-01 19:30:27 -04:00
2010-01-21 22:26:00 +01:00
2008-06-03 19:34:19 +02:00
2008-07-06 23:44:34 -07:00
2009-09-04 21:47:07 +02:00
2009-10-31 12:13:28 +01:00
2010-05-05 09:48:41 +02:00
2008-01-17 14:59:42 -06:00
2008-01-17 14:59:42 -06:00
2008-01-17 14:59:42 -06:00
2009-04-03 23:47:06 +02:00
2009-10-10 23:16:53 -07:00
2008-10-18 21:54:03 +02:00
2010-03-07 12:36:36 -06:00
2008-10-18 21:54:03 +02:00
2008-08-29 13:58:07 -06:00
2010-03-21 22:44:42 +01:00
2008-10-18 21:54:03 +02:00
2010-06-04 10:42:59 -05:00
2008-06-10 18:22:25 -05:00
2010-03-30 10:50:22 -05:00
2008-10-18 21:54:03 +02:00
2009-02-10 00:27:40 +01:00
2008-10-18 21:54:03 +02:00
2010-03-21 22:44:59 +01:00
2009-07-16 19:07:47 -05:00
2010-05-03 14:52:49 -07:00
2010-05-03 14:52:49 -07:00
2008-05-21 00:14:08 +02:00
2008-05-21 00:14:08 +02:00
2010-03-21 22:44:42 +01:00
2010-01-27 21:23:23 +01:00
2008-07-06 23:44:34 -07:00
2008-05-21 00:14:08 +02:00
2008-07-06 23:44:34 -07:00
2008-05-21 00:14:08 +02:00
2008-05-21 00:14:08 +02:00
2008-05-21 00:14:08 +02:00
2010-04-21 23:42:38 +02:00
2008-10-18 21:54:03 +02:00
2009-11-13 16:56:18 -06:00
2009-04-03 23:47:06 +02:00
2008-05-21 00:14:08 +02:00
2008-12-19 18:11:49 -06:00
2010-03-12 23:06:04 +01:00
2010-06-14 12:29:26 +02:00
2009-08-28 17:12:36 -05:00
2008-10-18 21:54:03 +02:00
2010-04-24 22:56:41 +02:00
2009-10-07 09:15:30 +02:00
2009-12-08 22:14:07 +01:00
2009-11-23 16:27:02 +01:00
2010-07-01 10:25:56 +02:00
2010-06-29 23:03:40 +02:00
2009-04-03 22:34:07 +02:00
2008-10-18 21:54:03 +02:00
2009-08-25 12:57:55 +02:00
2009-02-24 10:00:28 +01:00
2008-05-21 00:14:08 +02:00
2008-05-21 00:14:08 +02:00
2009-01-27 23:42:39 +01:00
2008-05-21 00:14:08 +02:00
2008-05-21 00:14:08 +02:00
2010-05-06 00:16:46 +02:00
2008-04-25 00:01:06 +02:00
2008-07-06 01:21:46 +02:00
2009-11-17 13:19:58 +01:00
2009-10-03 10:17:56 +02:00
2010-03-24 11:08:43 -05:00
2009-11-24 23:40:39 +01:00
2008-07-01 21:02:11 +02:00
2009-06-12 20:39:49 +02:00
2009-07-19 01:02:46 +02:00
2009-10-03 10:17:56 +02:00
2008-05-21 00:14:08 +02:00
2008-12-06 23:36:43 +01:00
2010-01-31 22:34:34 -08:00
2009-07-19 11:21:08 +02:00
2010-01-04 08:48:15 -06:00
2009-03-30 09:38:36 +02:00
2010-05-19 10:57:24 +02:00
2009-01-28 19:57:27 +01:00
2010-05-27 20:59:48 +02:00
2009-12-20 12:47:37 +01:00
2009-12-20 12:47:37 +01:00
2008-05-13 23:15:52 +02:00
2008-05-21 00:14:08 +02:00
2008-05-21 00:14:08 +02:00
2009-10-03 10:17:56 +02:00
2008-03-26 11:48:46 +01:00
2010-07-04 23:55:42 +02:00
2008-10-18 21:54:03 +02:00
2010-05-28 10:56:04 -04:00
2010-03-24 11:08:43 -05:00
54841ab50c